[mlgo][inliner] Tigher test for interactive mode #141677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompted by llvm#141453 - have the test check the feature that was previously clobbered in interactive mode, if the default decision was requested.
|
@llvm/pr-subscribers-llvm-transforms Author: Mircea Trofin (mtrofin) ChangesPrompted by #141453 - have the test check the feature that was previously clobbered in interactive mode, if the default decision was requested. Full diff: https://github.com/llvm/llvm-project/pull/141677.diff 1 Files Affected:
diff --git a/llvm/test/Transforms/Inline/ML/interactive-mode.ll b/llvm/test/Transforms/Inline/ML/interactive-mode.ll
index 0866d14c6ece7..28f87049b21db 100644
--- a/llvm/test/Transforms/Inline/ML/interactive-mode.ll
+++ b/llvm/test/Transforms/Inline/ML/interactive-mode.ll
@@ -22,10 +22,19 @@
; CHECK-NEXT: sroa_savings: 0
; CHECK: unsimplified_common_instructions: 5
; CHECK: callee_users: 3
+; CHECK-DEFAULT: inlining_default: 1
+; CHECK: observation: 1
+; CHECK: callee_basic_block_count: 5
+; CHECK-DEFAULT: inlining_default: 0
+; CHECK: observation: 2
+; CHECK-DEFAULT: inlining_default: 1
+; CHECK: observation: 3
+; CHECK: callee_basic_block_count: 1
; CHECK-DEFAULT: inlining_default: 0
+; CHECK: observation: 4
; CHECK-DEFAULT: inlining_default: 1
; CHECK: observation: 5
-; CHECK-NOT: observation: 6
+; CHECK-DEFAULT: inlining_default: 1
; CHECK: inlining_decision: 1
; CHECK-NEXT: inlining_decision: 0
|
|
fyi @jellytabby since can't (yet) be added to reviewer list. |
boomanaiden154
approved these changes
May 27, 2025
ivanradanov
approved these changes
May 27, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Prompted by llvm#141453 - have the test check the feature that was previously clobbered in interactive mode, if the default decision was requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #141453 - have the test check the feature that was previously clobbered in interactive mode, if the default decision was requested.