Skip to content

[lldb] Fix warnings #141687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

This patch fixes:

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4137:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4844:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5142:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]

This patch fixes:

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4137:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4844:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5142:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]
@llvmbot
Copy link
Member

llvmbot commented May 27, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

This patch fixes:

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4137:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4844:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5142:11:
error: enumeration value 'HLSLInlineSpirv' not handled in switch
[-Werror,-Wswitch]


Full diff: https://github.com/llvm/llvm-project/pull/141687.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+6)
diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 8c19d5be76bcf..16ea40bd5e9bc 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -4262,6 +4262,8 @@ TypeSystemClang::GetTypeClass(lldb::opaque_compiler_type_t type) {
 
   case clang::Type::HLSLAttributedResource:
     break;
+  case clang::Type::HLSLInlineSpirv:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
@@ -5128,6 +5130,8 @@ lldb::Encoding TypeSystemClang::GetEncoding(lldb::opaque_compiler_type_t type,
 
   case clang::Type::HLSLAttributedResource:
     break;
+  case clang::Type::HLSLInlineSpirv:
+    break;
   }
   count = 0;
   return lldb::eEncodingInvalid;
@@ -5292,6 +5296,8 @@ lldb::Format TypeSystemClang::GetFormat(lldb::opaque_compiler_type_t type) {
 
   case clang::Type::HLSLAttributedResource:
     break;
+  case clang::Type::HLSLInlineSpirv:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eFormatBytes;

@googlewalt
Copy link
Contributor

I don't have any expertise in this code, but it looks like it shouldn't break anything and fixes a bunch of build breakages, so I'm going to check it in.

@googlewalt googlewalt merged commit a69487d into llvm:main May 28, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_warning_HLSLInlineSpirv branch May 28, 2025 15:03
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
This patch fixes:

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4137:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4844:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]

  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5142:11:
  error: enumeration value 'HLSLInlineSpirv' not handled in switch
  [-Werror,-Wswitch]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants