fix llvm-gsymutil verification

[peremyach]

Verification crashed here https://github.com/llvm/llvm-project/blob/main/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp#L519
The reason being that during verification to extract inline_info we recreate compile unit dies. Assert fails because we previously cleaned up just the DIEs but some other fields remained initialized.

[llvmbot]

@llvm/pr-subscribers-debuginfo

Author: None (peremyach)

Changes

Verification crashed here https://github.com/llvm/llvm-project/blob/main/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp#L519
The reason being that we to extract inline_info we recreate compile unit dies. Assert fails because we previously cleaned up just the DIEs but some other fields remained initialized.

---

Full diff: https://github.com/llvm/llvm-project/pull/141751.diff

1 Files Affected:

• (modified) llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp (+4)

diff --git a/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp b/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
index 1f70d273a9d9d..640141463c107 100644
--- a/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
+++ b/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
@@ -713,6 +713,10 @@ llvm::Error DwarfTransformer::verify(StringRef GsymPath,
                                      OutputAggregator &Out) {
   Out << "Verifying GSYM file \"" << GsymPath << "\":\n";
 
+  for (const auto &CU : DICtx.compile_units()) {
+    CU->clear();
+  }
+
   auto Gsym = GsymReader::openFile(GsymPath);
   if (!Gsym)
     return Gsym.takeError();

[clayborg]

So if there is some state that wasn't cleared in the DWARFUnit objects (or DWARFCompileUnit objects) then we should be doing one of two things:

• Instead of calling void DWARFUnit::clearDIEs(bool KeepCUDie, bool KeepDWODies = false);, we call DWARFUnit::clear(). This should reset all of the state correctly and avoid the assertion
• in void clearDIEs(bool KeepCUDie, bool KeepDWODies = false); we should clear any state related to the DIEs that needs to be cleared.

[Jlalond]

@peremyach want me to merge this for you?

[peremyach]

@Jlalond yes, please