Skip to content

[libc++] Run macOS jobs after the Stage 2 CI #141816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented May 28, 2025

Our CI is currently having major difficulties, which causes the Stage 3 CI to basically never succeed. As a result, our macOS CI jobs have not been running recently. This patch gates the macOS CI jobs on Stage 2 instead of Stage 3 so that they actually run sometimes.

@ldionne ldionne marked this pull request as ready for review May 28, 2025 18:21
@llvmbot llvmbot added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. github:workflow labels May 28, 2025
@llvmbot
Copy link
Member

llvmbot commented May 28, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Our CI is currently having major difficulties, which causes the Stage 3 CI to basically never succeed. As a result, our macOS CI jobs have not been running recently. This patch gates the macOS CI jobs on Stage 2 instead of Stage 3 so that they actually run sometimes.


Full diff: https://github.com/llvm/llvm-project/pull/141816.diff

1 Files Affected:

  • (modified) .github/workflows/libcxx-build-and-test.yaml (+1-1)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index d05e6a559e28d..80f2432b78dea 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -184,7 +184,7 @@ jobs:
             **/crash_diagnostics/*
 
   macos:
-    needs: [ stage3 ]
+    needs: [ stage2 ]
     strategy:
       fail-fast: false
       matrix:

@llvmbot
Copy link
Member

llvmbot commented May 28, 2025

@llvm/pr-subscribers-github-workflow

Author: Louis Dionne (ldionne)

Changes

Our CI is currently having major difficulties, which causes the Stage 3 CI to basically never succeed. As a result, our macOS CI jobs have not been running recently. This patch gates the macOS CI jobs on Stage 2 instead of Stage 3 so that they actually run sometimes.


Full diff: https://github.com/llvm/llvm-project/pull/141816.diff

1 Files Affected:

  • (modified) .github/workflows/libcxx-build-and-test.yaml (+1-1)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index d05e6a559e28d..80f2432b78dea 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -184,7 +184,7 @@ jobs:
             **/crash_diagnostics/*
 
   macos:
-    needs: [ stage3 ]
+    needs: [ stage2 ]
     strategy:
       fail-fast: false
       matrix:

Our CI is currently having major difficulties, which causes the Stage 3
CI to basically never succeed. As a result, our macOS CI jobs have not
been running recently. This patch gates the macOS CI jobs on Stage 2
instead of Stage 3 so that they actually run sometimes.
@ldionne ldionne force-pushed the review/macos-ci-shuffle branch from 9ab6afb to 4d63d0a Compare May 28, 2025 18:32
@ldionne ldionne merged commit 4194192 into llvm:main May 29, 2025
67 of 73 checks passed
@ldionne ldionne deleted the review/macos-ci-shuffle branch May 29, 2025 16:30
svkeerthy pushed a commit that referenced this pull request May 29, 2025
Our CI is currently having major difficulties, which causes the Stage 3
CI to basically never succeed. As a result, our macOS CI jobs have not
been running recently. This patch gates the macOS CI jobs on Stage 2
instead of Stage 3 so that they actually run sometimes.
google-yfyang pushed a commit to google-yfyang/llvm-project that referenced this pull request May 29, 2025
Our CI is currently having major difficulties, which causes the Stage 3
CI to basically never succeed. As a result, our macOS CI jobs have not
been running recently. This patch gates the macOS CI jobs on Stage 2
instead of Stage 3 so that they actually run sometimes.
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Our CI is currently having major difficulties, which causes the Stage 3
CI to basically never succeed. As a result, our macOS CI jobs have not
been running recently. This patch gates the macOS CI jobs on Stage 2
instead of Stage 3 so that they actually run sometimes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github:workflow libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants