-
Notifications
You must be signed in to change notification settings - Fork 14.5k
[Github] Bump PR Code Format clang-format version #141819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] Bump PR Code Format clang-format version #141819
Conversation
As we have discussed in the past, we should be using the latest version. This has not been updated in a while.
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesAs we have discussed in the past, we should be using the latest version. This has not been updated in a while. Full diff: https://github.com/llvm/llvm-project/pull/141819.diff 1 Files Affected:
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 063fe5679a399..05d69861e1841 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -55,7 +55,7 @@ jobs:
- name: Install clang-format
uses: aminya/setup-cpp@17c11551771948abc5752bbf3183482567c7caf0 # v1.1.1
with:
- clangformat: 19.1.6
+ clangformat: 20.1.5
- name: Setup Python env
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
|
Maybe we could automate bumping this when we do a release? |
Potentially. Something like the version bump script should work. |
As we have discussed in the past, we should be using the latest version. This has not been updated in a while.
I was about to update the version and was waiting for 20.1.6, which has at least one relevant bug fix. Also, I don't anticipate any more clang-format patches for 20.1.x, so we don't need to wait for the final 20.1.x release.
We should probably do it for the .0 release (optional) and at the end of a release. |
End of a release cycle sounds good to me. I was going to say we need to update the documentation, but it doesn't look like the coding standards mention |
As we have discussed in the past, we should be using the latest version. This has not been updated in a while.
As we have discussed in the past, we should be using the latest version. This has not been updated in a while.