[lldb] Fix TestFrameLanguageCommands.py build #141829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) ChangesFull diff: https://github.com/llvm/llvm-project/pull/141829.diff 1 Files Affected:
diff --git a/lldb/test/API/commands/command/language/Makefile b/lldb/test/API/commands/command/language/Makefile
index 2d5049417ee70..ce845d59ac035 100644
--- a/lldb/test/API/commands/command/language/Makefile
+++ b/lldb/test/API/commands/command/language/Makefile
@@ -1,4 +1,3 @@
OBJCXX_SOURCES := main.mm
CXX_SOURCES := lib.cpp
-LD_EXTRAS := -lobjc
include Makefile.rules
|
|
See #136766 |
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
May 29, 2025
The use of `-lobjc` resulted in this test failing to build on Linux. The flag is not necessary, this removes the flag with the expectation it will fix the test on Linux. (cherry-picked from commit e653dc9)
google-yfyang
pushed a commit
to google-yfyang/llvm-project
that referenced
this pull request
May 29, 2025
The use of `-lobjc` resulted in this test failing to build on Linux. The flag is not necessary, this removes the flag with the expectation it will fix the test on Linux.
adrian-prantl
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 2, 2025
…rent frame (llvm#136766) (#10755) * [lldb] Expose language plugin commands based based on language of current frame (llvm#136766) Use the current frame's language to lookup commands provided by language plugins. This means commands like `language {objc,cplusplus} <command>` can be used directly, without using the `language <lang>` prefix. For example, when stopped on a C++ frame, `demangle _Z1fv` will run `language cplusplus demangle _Z1fv`. rdar://149882520 (cherry picked from commit 7ed185a) * [lldb] Fix typo in tagged-pointer syntax string (NFC) (llvm#137069) (cherry-picked from commit cef9ed5) * [lldb] Run TestFrameLanguageCommands.py only on Darwin (llvm#141866) Tests using ObjC do not readily run on Linux. (cherry-picked from commit 1d48e55) * [lldb] Fix TestFrameLanguageCommands.py build (llvm#141829) The use of `-lobjc` resulted in this test failing to build on Linux. The flag is not necessary, this removes the flag with the expectation it will fix the test on Linux. (cherry-picked from commit e653dc9)
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
The use of `-lobjc` resulted in this test failing to build on Linux. The flag is not necessary, this removes the flag with the expectation it will fix the test on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
-lobjcresulted in this test failing to build on Linux. The flag is not necessary, this removes the flag with the expectation it will fix the test on Linux.