Skip to content

[AArch64] Add MSVC-style mangling for SVE types. #141887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

[AArch64] Add MSVC-style mangling for SVE types. #141887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clang/lib/AST/MicrosoftMangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,6 +2828,13 @@ void MicrosoftCXXNameMangler::mangleType(const BuiltinType *T, Qualifiers,
break;
#include "clang/Basic/HLSLIntangibleTypes.def"

#define SVE_TYPE(Name, Id, SingletonId) \
case BuiltinType::Id: \
mangleArtificialTagType(TagTypeKind::Struct, #Name, {"__clang"}); \
break;
#define SVE_SCALAR_TYPE(Name, MangledName, Id, SingletonId, Bits)
#include "clang/Basic/AArch64ACLETypes.def"

// Issue an error for any type not explicitly handled.
default:
Error(Range.getBegin(), "built-in type: ",
Expand Down
12 changes: 9 additions & 3 deletions clang/test/CodeGenCXX/aarch64-mangle-sve-vectors-msvc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
// RUN: not %clang_cc1 -triple aarch64-unknown-windows-msvc %s -emit-llvm \
// RUN: -o - 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple aarch64-unknown-windows-msvc %s -emit-llvm \
// RUN: -o - | FileCheck %s

template<typename T> struct S {};

// CHECK: cannot mangle this built-in type: __SVInt8_t yet
// CHECK: void @"?f1@@YAXU?$S@U__SVInt8_t@__clang@@@@@Z"
void f1(S<__SVInt8_t>) {}
// CHECK: void @"?f2@@YAXU?$S@U__SVInt32_t@__clang@@@@@Z"
void f2(S<__SVInt32_t>) {}
// CHECK: void @"?f3@@YAXU?$S@U__SVBool_t@__clang@@@@@Z"
void f3(S<__SVBool_t>) {}
// CHECK: void @"?f4@@YAXU?$S@U__clang_svfloat64x4_t@__clang@@@@@Z"
void f4(S<__clang_svfloat64x4_t>) {}
Loading