Skip to content

[cmake][clang-tools] Make split-file a dependency for tests #142048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

ilovepi
Copy link
Contributor

@ilovepi ilovepi commented May 29, 2025

clang-doc uses split-file in some tests. We didn't notice the missing
dep, since its always built before clang-tools-extra tests run in CI.

clang-doc uses split-file in some tests. We didn't notice the missing
dep, since its always built before clang-tools-extra tests run in CI.
Copy link
Contributor Author

ilovepi commented May 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented May 29, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Paul Kirth (ilovepi)

Changes

clang-doc uses split-file in some tests. We didn't notice the missing
dep, since its always built before clang-tools-extra tests run in CI.


Full diff: https://github.com/llvm/llvm-project/pull/142048.diff

1 Files Affected:

  • (modified) clang-tools-extra/test/CMakeLists.txt (+1-1)
diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index 7e4d99d8cfc1d..d8175d1b2b6d0 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -54,7 +54,7 @@ set(CLANG_TOOLS_TEST_DEPS
 
 # Add lit test dependencies.
 set(LLVM_UTILS_DEPS
-  FileCheck count not
+  FileCheck count not split-file
 )
 foreach(dep ${LLVM_UTILS_DEPS})
   if(TARGET ${dep})

@ilovepi ilovepi merged commit f1886b1 into main May 30, 2025
13 checks passed
@ilovepi ilovepi deleted the users/ilovepi/clang-doc-split-file-dep branch May 30, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants