Skip to content

[ci] Use different emoji for Linux and Windows job titles on GitHub #142101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented May 30, 2025

Buildkite has a bunch of custom emoji that include Linux and Windows logos - https://github.com/buildkite/emojis?tab=readme-ov-file#smileys--emotion.

GitHub doesn't have these so let's just use a penguin and a generic window. 🐧 🪟

These are standard emoji so Buildkite does support them too, but there's no motivation to change it there.

Plus, I think the metrics collection might be tied to Buildkite pipeline name so keeping it the same saves hassle there.

Buildkite has a bunch of custom emoji that include
Linux and Windows logos - https://github.com/buildkite/emojis?tab=readme-ov-file#smileys--emotion.

GitHub doesn't have these so let's just use a penguin
and a generic window.

These are standard emoji so Buildkite does support
them too, but there's no motivation to change it there.

Plus, I think the metrics collection might be tied to Buildkite
pipeline name so keeping it the same saves hassle there.
@DavidSpickett DavidSpickett changed the title [ci] Use different emoji for Linux Windows job titles on GitHub [ci] Use different emoji for Linux and Windows job titles on GitHub May 30, 2025
@DavidSpickett
Copy link
Collaborator Author

Looks like the metrics might cope with a pipeline name change -

# Lists the BuildKite jobs we want to track. Maps the BuildKite job name to
, but no point taking the risk just for some emoji.

Example build where GitHub just prints :linux: https://github.com/llvm/llvm-project/actions/runs/15337076175.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's markdown, I'm guessing we could probably get <img> tags to display what we want. Probably more hassle than it's worth though. This is definitely the most reasonable path forward currently.

Thanks for the patch!

@DavidSpickett DavidSpickett merged commit bd3c632 into llvm:main Jun 2, 2025
12 checks passed
@DavidSpickett DavidSpickett deleted the ci-emoji branch June 2, 2025 08:22
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
…lvm#142101)

Buildkite has a bunch of custom emoji that include Linux and Windows
logos -
https://github.com/buildkite/emojis?tab=readme-ov-file#smileys--emotion.

GitHub doesn't have these so let's just use a penguin and a generic
window. 🐧 🪟

These are standard emoji so Buildkite does support them too, but there's
no motivation to change it there.

Plus, I think the metrics collection might be tied to Buildkite pipeline
name so keeping it the same saves hassle there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants