-
Notifications
You must be signed in to change notification settings - Fork 14k
[lldb] Disable TestReverseContinueBreakpoints.py and TestReverseContinueWatchpoints.py for Windows x86_64 #142193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slydiman
merged 1 commit into
llvm:main
from
slydiman:disable-TestReverseContinue-x86_64
Jun 2, 2025
Merged
[lldb] Disable TestReverseContinueBreakpoints.py and TestReverseContinueWatchpoints.py for Windows x86_64 #142193
slydiman
merged 1 commit into
llvm:main
from
slydiman:disable-TestReverseContinue-x86_64
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nueWatchpoints.py for Windows x86_64 See llvm#138084 for details.
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesSee #138084 for details. Full diff: https://github.com/llvm/llvm-project/pull/142193.diff 2 Files Affected:
diff --git a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
index 0a5f2d88fb917..53c8cdd4540a2 100644
--- a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
+++ b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
@@ -63,10 +63,20 @@ def reverse_continue_breakpoint_internal(self, async_mode):
self.assertEqual(threads_now, initial_threads)
@skipIfRemote
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_breakpoint(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=False)
@skipIfRemote
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_breakpoint_async(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=True)
diff --git a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
index a9e1bec5750e7..38cf5fced4944 100644
--- a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
+++ b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
@@ -64,12 +64,22 @@ def reverse_continue_watchpoint_internal(self, async_mode):
@skipIfRemote
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_watchpoint(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=False)
@skipIfRemote
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_watchpoint_async(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=True)
|
@llvm/pr-subscribers-platform-windows Author: Dmitry Vasilyev (slydiman) ChangesSee #138084 for details. Full diff: https://github.com/llvm/llvm-project/pull/142193.diff 2 Files Affected:
diff --git a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
index 0a5f2d88fb917..53c8cdd4540a2 100644
--- a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
+++ b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
@@ -63,10 +63,20 @@ def reverse_continue_breakpoint_internal(self, async_mode):
self.assertEqual(threads_now, initial_threads)
@skipIfRemote
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_breakpoint(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=False)
@skipIfRemote
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_breakpoint_async(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=True)
diff --git a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
index a9e1bec5750e7..38cf5fced4944 100644
--- a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
+++ b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
@@ -64,12 +64,22 @@ def reverse_continue_watchpoint_internal(self, async_mode):
@skipIfRemote
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_watchpoint(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=False)
@skipIfRemote
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
+ @skipIf(
+ oslist=["windows"],
+ archs=["x86_64"],
+ bugnumber="github.com/llvm/llvm-project/issues/138084",
+ )
def test_reverse_continue_skip_watchpoint_async(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=True)
|
labath
approved these changes
Jun 2, 2025
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
…nueWatchpoints.py for Windows x86_64 (llvm#142193) See llvm#138084 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #138084 for details.