Skip to content

[symbolizer] Update Release notes. #142951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Conversation

da-viper
Copy link
Contributor

@da-viper da-viper commented Jun 5, 2025

Also add post-commit changes from commit #71ba852

in PR #135857

Also add post-commit changes from commit #71ba852
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: Ebuka Ezike (da-viper)

Changes

Also add post-commit changes from commit #71ba852

in PR #135857


Full diff: https://github.com/llvm/llvm-project/pull/142951.diff

4 Files Affected:

  • (modified) llvm/docs/CommandGuide/llvm-addr2line.rst (+3)
  • (modified) llvm/docs/ReleaseNotes.md (+1)
  • (modified) llvm/test/tools/llvm-symbolizer/symbol-search.test (+1-1)
  • (modified) llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp (+1-1)
diff --git a/llvm/docs/CommandGuide/llvm-addr2line.rst b/llvm/docs/CommandGuide/llvm-addr2line.rst
index 646a159cd24a6..49faa3c5e811e 100644
--- a/llvm/docs/CommandGuide/llvm-addr2line.rst
+++ b/llvm/docs/CommandGuide/llvm-addr2line.rst
@@ -36,6 +36,9 @@ Here are some of those differences:
 -  ``llvm-addr2line`` parses options from the environment variable
    ``LLVM_ADDR2LINE_OPTS`` instead of from ``LLVM_SYMBOLIZER_OPTS``.
 
+- ``llvm-addr2line`` accepts an address with a '+' prefix ie `+0x00777fff`
+  this is not valid in ``llvm-symbolizer``
+
 SEE ALSO
 --------
 
diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md
index 7d734f2e258e6..280744aaf780f 100644
--- a/llvm/docs/ReleaseNotes.md
+++ b/llvm/docs/ReleaseNotes.md
@@ -265,6 +265,7 @@ Changes to the LLVM tools
 * llvm-strip now supports continuing to process files on encountering an error.
 * In llvm-objcopy/llvm-strip's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations.
   ([#47468](https://github.com/llvm/llvm-project/issues/47468))
+* llvm-addr2line now supports a `+` prefix when specifying an address.
 
 Changes to LLDB
 ---------------------------------
diff --git a/llvm/test/tools/llvm-symbolizer/symbol-search.test b/llvm/test/tools/llvm-symbolizer/symbol-search.test
index b785cf1596fad..bb07c54e100b5 100644
--- a/llvm/test/tools/llvm-symbolizer/symbol-search.test
+++ b/llvm/test/tools/llvm-symbolizer/symbol-search.test
@@ -66,7 +66,7 @@ RUN: llvm-addr2line --obj=%p/Inputs/symbols.so func_01+0A | FileCheck --check-pr
 
 # If '+' is not preceded by a symbol, it is part of a symbol name, not an offset separator.
 RUN: llvm-symbolizer --obj=%p/Inputs/symbols.so +0x1138 | FileCheck --check-prefix=NONEXISTENT %s
-# in addr2line address starting with a `+` sign is a valid address
+# In addr2line address starting with a `+` sign is a valid address.
 RUN: llvm-addr2line --obj=%p/Inputs/symbols.so +0x1138 | FileCheck --check-prefix=CODE-CMD %s
 
 # Show that C++ mangled names may be specified.
diff --git a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
index a682a0762c393..4784dafeb2948 100644
--- a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
+++ b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
@@ -238,7 +238,7 @@ static Error parseCommand(StringRef BinaryName, bool IsAddr2Line,
   bool StartsWithDigit = std::isdigit(AddrSpec.front());
 
   // GNU addr2line assumes the address is hexadecimal and allows a redundant
-  // "0x" or "0X" prefix or with an optional `+` sign; do the same for
+  // "0x", "0X" prefix or an optional `+` sign; do the same for
   // compatibility.
   if (IsAddr2Line) {
     AddrSpec.consume_front_insensitive("0x") ||

Co-authored-by: James Henderson <James.Henderson@sony.com>
Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@da-viper da-viper merged commit 89d2d62 into llvm:main Jun 6, 2025
8 checks passed
@da-viper da-viper deleted the post-commit-symbolizers branch June 6, 2025 12:25
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
Also add post-commit changes from commit #71ba852

in PR llvm#135857

---------

Co-authored-by: James Henderson <James.Henderson@sony.com>
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
Also add post-commit changes from commit #71ba852

in PR llvm#135857

---------

Co-authored-by: James Henderson <James.Henderson@sony.com>
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
Also add post-commit changes from commit #71ba852

in PR llvm#135857

---------

Co-authored-by: James Henderson <James.Henderson@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants