Conditionalise the addition of Aarch64 function Multi versioning support on aarch64 target #143749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -884,7 +884,11 @@ else () | |||
| if(COMPILER_RT_DISABLE_AARCH64_FMV) | |||
| list(APPEND BUILTIN_DEFS DISABLE_AARCH64_FMV) | |||
| elseif(COMPILER_RT_BAREMETAL_BUILD) | |||
| list(APPEND BUILTIN_DEFS ENABLE_BAREMETAL_AARCH64_FMV) | |||
| foreach (arch ${BUILTIN_SUPPORTED_ARCH}) | |||
| if("${arch}" STREQUAL "aarch64") | |||
There was a problem hiding this comment.
This will miss some target names which may also require ENABLE_BAREMETAL_AARCH64_FMV (e.g. arm64, arm64ec). I think we can use something like this instead:
Suggested change
| if("${arch}" STREQUAL "aarch64") | |
| if("${arch}" MATCHES "arm64|aarch64") |
support on aarch64 target Currently, `ENABLE_BAREMETAL_AARCH64_FMV` is added to builtin defines for all baremetal targets though it is only needed for aarch64. This patch fixes this by adding it only for aarch64 target. Change-Id: Ie469d01961e9d4992c1a430d7e9b089ae9549079
kmclaughlin-arm
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ENABLE_BAREMETAL_AARCH64_FMVis added to builtin defines for all baremetal targets though it is only needed for aarch64. This patch fixes this by adding it only for aarch64 target.