[lldb] Add support to list/enable/disable remaining plugin types. #143970
+566
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the only plugin type that was not using the PluginInstance wrapper. It needs to use the PluginInstances to hook into the enable/disable support.
In llvm#134418 we added support to list/enable/disable SystemRuntime and InstrumentationRuntime plugins. We limited it to those two plugin types to flesh out the idea with a smaller change. This PR adds support for the remaining plugin types. We now support all the plugins that can be registered directly with the plugin manager. Plugins that are added by loading shared objects are still not supported.
|
@llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) ChangesIn #134418 we added support to list/enable/disable This PR adds support for the remaining plugin types. We now support all Patch is 27.41 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/143970.diff 4 Files Affected:
diff --git a/lldb/include/lldb/Core/PluginManager.h b/lldb/include/lldb/Core/PluginManager.h
index e7b1691031111..1d7c976f3c382 100644
--- a/lldb/include/lldb/Core/PluginManager.h
+++ b/lldb/include/lldb/Core/PluginManager.h
@@ -236,12 +236,6 @@ class PluginManager {
static SystemRuntimeCreateInstance
GetSystemRuntimeCreateCallbackAtIndex(uint32_t idx);
- static std::vector<RegisteredPluginInfo> GetSystemRuntimePluginInfo();
-
- // Modify the enabled state of a SystemRuntime plugin.
- // Returns false if the plugin name is not found.
- static bool SetSystemRuntimePluginEnabled(llvm::StringRef name, bool enabled);
-
// ObjectFile
static bool
RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
@@ -549,12 +543,6 @@ class PluginManager {
static InstrumentationRuntimeCreateInstance
GetInstrumentationRuntimeCreateCallbackAtIndex(uint32_t idx);
- static std::vector<RegisteredPluginInfo>
- GetInstrumentationRuntimePluginInfo();
-
- static bool SetInstrumentationRuntimePluginEnabled(llvm::StringRef name,
- bool enabled);
-
// TypeSystem
static bool RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
TypeSystemCreateInstance create_callback,
@@ -690,6 +678,102 @@ class PluginManager {
static bool CreateSettingForCPlusPlusLanguagePlugin(
Debugger &debugger, const lldb::OptionValuePropertiesSP &properties_sp,
llvm::StringRef description, bool is_global_property);
+
+ //
+ // Plugin Info+Enable Declarations
+ //
+ static std::vector<RegisteredPluginInfo> GetABIPluginInfo();
+ static bool SetABIPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetArchitecturePluginInfo();
+ static bool SetArchitecturePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetDisassemblerPluginInfo();
+ static bool SetDisassemblerPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetDynamicLoaderPluginInfo();
+ static bool SetDynamicLoaderPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetEmulateInstructionPluginInfo();
+ static bool SetEmulateInstructionPluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo>
+ GetInstrumentationRuntimePluginInfo();
+ static bool SetInstrumentationRuntimePluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetJITLoaderPluginInfo();
+ static bool SetJITLoaderPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetLanguagePluginInfo();
+ static bool SetLanguagePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetLanguageRuntimePluginInfo();
+ static bool SetLanguageRuntimePluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetMemoryHistoryPluginInfo();
+ static bool SetMemoryHistoryPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetObjectContainerPluginInfo();
+ static bool SetObjectContainerPluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetObjectFilePluginInfo();
+ static bool SetObjectFilePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetOperatingSystemPluginInfo();
+ static bool SetOperatingSystemPluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetPlatformPluginInfo();
+ static bool SetPlatformPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetProcessPluginInfo();
+ static bool SetProcessPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetREPLPluginInfo();
+ static bool SetREPLPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetRegisterTypeBuilderPluginInfo();
+ static bool SetRegisterTypeBuilderPluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetScriptInterpreterPluginInfo();
+ static bool SetScriptInterpreterPluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetScriptedInterfacePluginInfo();
+ static bool SetScriptedInterfacePluginEnabled(llvm::StringRef name,
+ bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetStructuredDataPluginInfo();
+ static bool SetStructuredDataPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetSymbolFilePluginInfo();
+ static bool SetSymbolFilePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetSymbolLocatorPluginInfo();
+ static bool SetSymbolLocatorPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetSymbolVendorPluginInfo();
+ static bool SetSymbolVendorPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetSystemRuntimePluginInfo();
+ static bool SetSystemRuntimePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetTracePluginInfo();
+ static bool SetTracePluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetTraceExporterPluginInfo();
+ static bool SetTraceExporterPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetTypeSystemPluginInfo();
+ static bool SetTypeSystemPluginEnabled(llvm::StringRef name, bool enable);
+
+ static std::vector<RegisteredPluginInfo> GetUnwindAssemblyPluginInfo();
+ static bool SetUnwindAssemblyPluginEnabled(llvm::StringRef name, bool enable);
};
} // namespace lldb_private
diff --git a/lldb/source/Core/PluginManager.cpp b/lldb/source/Core/PluginManager.cpp
index 5d44434033c55..dfa865929b64f 100644
--- a/lldb/source/Core/PluginManager.cpp
+++ b/lldb/source/Core/PluginManager.cpp
@@ -182,14 +182,176 @@ void PluginManager::Terminate() {
}
llvm::ArrayRef<PluginNamespace> PluginManager::GetPluginNamespaces() {
- // Currently supported set of plugin namespaces. This will be expanded
- // over time.
static PluginNamespace PluginNamespaces[] = {
- {"system-runtime", PluginManager::GetSystemRuntimePluginInfo,
- PluginManager::SetSystemRuntimePluginEnabled},
- {"instrumentation-runtime",
- PluginManager::GetInstrumentationRuntimePluginInfo,
- PluginManager::SetInstrumentationRuntimePluginEnabled}};
+
+ {
+ "abi",
+ PluginManager::GetABIPluginInfo,
+ PluginManager::SetABIPluginEnabled,
+ },
+
+ {
+ "architecture",
+ PluginManager::GetArchitecturePluginInfo,
+ PluginManager::SetArchitecturePluginEnabled,
+ },
+
+ {
+ "disassembler",
+ PluginManager::GetDisassemblerPluginInfo,
+ PluginManager::SetDisassemblerPluginEnabled,
+ },
+
+ {
+ "dynamic-loader",
+ PluginManager::GetDynamicLoaderPluginInfo,
+ PluginManager::SetDynamicLoaderPluginEnabled,
+ },
+
+ {
+ "emulate-instruction",
+ PluginManager::GetEmulateInstructionPluginInfo,
+ PluginManager::SetEmulateInstructionPluginEnabled,
+ },
+
+ {
+ "instrumentation-runtime",
+ PluginManager::GetInstrumentationRuntimePluginInfo,
+ PluginManager::SetInstrumentationRuntimePluginEnabled,
+ },
+
+ {
+ "jit-loader",
+ PluginManager::GetJITLoaderPluginInfo,
+ PluginManager::SetJITLoaderPluginEnabled,
+ },
+
+ {
+ "language",
+ PluginManager::GetLanguagePluginInfo,
+ PluginManager::SetLanguagePluginEnabled,
+ },
+
+ {
+ "language-runtime",
+ PluginManager::GetLanguageRuntimePluginInfo,
+ PluginManager::SetLanguageRuntimePluginEnabled,
+ },
+
+ {
+ "memory-history",
+ PluginManager::GetMemoryHistoryPluginInfo,
+ PluginManager::SetMemoryHistoryPluginEnabled,
+ },
+
+ {
+ "object-container",
+ PluginManager::GetObjectContainerPluginInfo,
+ PluginManager::SetObjectContainerPluginEnabled,
+ },
+
+ {
+ "object-file",
+ PluginManager::GetObjectFilePluginInfo,
+ PluginManager::SetObjectFilePluginEnabled,
+ },
+
+ {
+ "operating-system",
+ PluginManager::GetOperatingSystemPluginInfo,
+ PluginManager::SetOperatingSystemPluginEnabled,
+ },
+
+ {
+ "platform",
+ PluginManager::GetPlatformPluginInfo,
+ PluginManager::SetPlatformPluginEnabled,
+ },
+
+ {
+ "process",
+ PluginManager::GetProcessPluginInfo,
+ PluginManager::SetProcessPluginEnabled,
+ },
+
+ {
+ "repl",
+ PluginManager::GetREPLPluginInfo,
+ PluginManager::SetREPLPluginEnabled,
+ },
+
+ {
+ "register-type-builder",
+ PluginManager::GetRegisterTypeBuilderPluginInfo,
+ PluginManager::SetRegisterTypeBuilderPluginEnabled,
+ },
+
+ {
+ "script-interpreter",
+ PluginManager::GetScriptInterpreterPluginInfo,
+ PluginManager::SetScriptInterpreterPluginEnabled,
+ },
+
+ {
+ "scripted-interface",
+ PluginManager::GetScriptedInterfacePluginInfo,
+ PluginManager::SetScriptedInterfacePluginEnabled,
+ },
+
+ {
+ "structured-data",
+ PluginManager::GetStructuredDataPluginInfo,
+ PluginManager::SetStructuredDataPluginEnabled,
+ },
+
+ {
+ "symbol-file",
+ PluginManager::GetSymbolFilePluginInfo,
+ PluginManager::SetSymbolFilePluginEnabled,
+ },
+
+ {
+ "symbol-locator",
+ PluginManager::GetSymbolLocatorPluginInfo,
+ PluginManager::SetSymbolLocatorPluginEnabled,
+ },
+
+ {
+ "symbol-vendor",
+ PluginManager::GetSymbolVendorPluginInfo,
+ PluginManager::SetSymbolVendorPluginEnabled,
+ },
+
+ {
+ "system-runtime",
+ PluginManager::GetSystemRuntimePluginInfo,
+ PluginManager::SetSystemRuntimePluginEnabled,
+ },
+
+ {
+ "trace",
+ PluginManager::GetTracePluginInfo,
+ PluginManager::SetTracePluginEnabled,
+ },
+
+ {
+ "trace-exporter",
+ PluginManager::GetTraceExporterPluginInfo,
+ PluginManager::SetTraceExporterPluginEnabled,
+ },
+
+ {
+ "type-system",
+ PluginManager::GetTypeSystemPluginInfo,
+ PluginManager::SetTypeSystemPluginEnabled,
+ },
+
+ {
+ "unwind-assembly",
+ PluginManager::GetUnwindAssemblyPluginInfo,
+ PluginManager::SetUnwindAssemblyPluginEnabled,
+ },
+ };
return PluginNamespaces;
}
@@ -407,7 +569,7 @@ ABICreateInstance PluginManager::GetABICreateCallbackAtIndex(uint32_t idx) {
#pragma mark Architecture
typedef PluginInstance<ArchitectureCreateInstance> ArchitectureInstance;
-typedef std::vector<ArchitectureInstance> ArchitectureInstances;
+typedef PluginInstances<ArchitectureInstance> ArchitectureInstances;
static ArchitectureInstances &GetArchitectureInstances() {
static ArchitectureInstances g_instances;
@@ -417,25 +579,18 @@ static ArchitectureInstances &GetArchitectureInstances() {
void PluginManager::RegisterPlugin(llvm::StringRef name,
llvm::StringRef description,
ArchitectureCreateInstance create_callback) {
- GetArchitectureInstances().push_back({name, description, create_callback});
+ GetArchitectureInstances().RegisterPlugin(name, description, create_callback);
}
void PluginManager::UnregisterPlugin(
ArchitectureCreateInstance create_callback) {
auto &instances = GetArchitectureInstances();
-
- for (auto pos = instances.begin(), end = instances.end(); pos != end; ++pos) {
- if (pos->create_callback == create_callback) {
- instances.erase(pos);
- return;
- }
- }
- llvm_unreachable("Plugin not found");
+ instances.UnregisterPlugin(create_callback);
}
std::unique_ptr<Architecture>
PluginManager::CreateArchitectureInstance(const ArchSpec &arch) {
- for (const auto &instances : GetArchitectureInstances()) {
+ for (const auto &instances : GetArchitectureInstances().GetSnapshot()) {
if (auto plugin_up = instances.create_callback(arch))
return plugin_up;
}
@@ -718,15 +873,6 @@ PluginManager::GetSystemRuntimeCreateCallbackAtIndex(uint32_t idx) {
return GetSystemRuntimeInstances().GetCallbackAtIndex(idx);
}
-std::vector<RegisteredPluginInfo> PluginManager::GetSystemRuntimePluginInfo() {
- return GetSystemRuntimeInstances().GetPluginInfoForAllInstances();
-}
-
-bool PluginManager::SetSystemRuntimePluginEnabled(llvm::StringRef name,
- bool enable) {
- return GetSystemRuntimeInstances().SetInstanceEnabled(name, enable);
-}
-
#pragma mark ObjectFile
struct ObjectFileInstance : public PluginInstance<ObjectFileCreateInstance> {
@@ -1563,16 +1709,6 @@ PluginManager::GetInstrumentationRuntimeCreateCallbackAtIndex(uint32_t idx) {
return GetInstrumentationRuntimeInstances().GetCallbackAtIndex(idx);
}
-std::vector<RegisteredPluginInfo>
-PluginManager::GetInstrumentationRuntimePluginInfo() {
- return GetInstrumentationRuntimeInstances().GetPluginInfoForAllInstances();
-}
-
-bool PluginManager::SetInstrumentationRuntimePluginEnabled(llvm::StringRef name,
- bool enable) {
- return GetInstrumentationRuntimeInstances().SetInstanceEnabled(name, enable);
-}
-
#pragma mark TypeSystem
struct TypeSystemInstance : public PluginInstance<TypeSystemCreateInstance> {
@@ -2057,3 +2193,234 @@ bool PluginManager::CreateSettingForCPlusPlusLanguagePlugin(
"Settings for CPlusPlus language plug-ins",
properties_sp, description, is_global_property);
}
+
+//
+// Plugin Info+Enable Implementations
+//
+std::vector<RegisteredPluginInfo> PluginManager::GetABIPluginInfo() {
+ return GetABIInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetABIPluginEnabled(llvm::StringRef name, bool enable) {
+ return GetABIInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetArchitecturePluginInfo() {
+ return GetArchitectureInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetArchitecturePluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetArchitectureInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetDisassemblerPluginInfo() {
+ return GetDisassemblerInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetDisassemblerPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetDisassemblerInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetDynamicLoaderPluginInfo() {
+ return GetDynamicLoaderInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetDynamicLoaderPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetDynamicLoaderInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo>
+PluginManager::GetEmulateInstructionPluginInfo() {
+ return GetEmulateInstructionInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetEmulateInstructionPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetEmulateInstructionInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo>
+PluginManager::GetInstrumentationRuntimePluginInfo() {
+ return GetInstrumentationRuntimeInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetInstrumentationRuntimePluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetInstrumentationRuntimeInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetJITLoaderPluginInfo() {
+ return GetJITLoaderInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetJITLoaderPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetJITLoaderInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetLanguagePluginInfo() {
+ return GetLanguageInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetLanguagePluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetLanguageInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo>
+PluginManager::GetLanguageRuntimePluginInfo() {
+ return GetLanguageRuntimeInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetLanguageRuntimePluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetLanguageRuntimeInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetMemoryHistoryPluginInfo() {
+ return GetMemoryHistoryInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetMemoryHistoryPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetMemoryHistoryInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo>
+PluginManager::GetObjectContainerPluginInfo() {
+ return GetObjectContainerInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetObjectContainerPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetObjectContainerInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetObjectFilePluginInfo() {
+ return GetObjectFileInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetObjectFilePluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetObjectFileInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo>
+PluginManager::GetOperatingSystemPluginInfo() {
+ return GetOperatingSystemInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetOperatingSystemPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetOperatingSystemInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetPlatformPluginInfo() {
+ return GetPlatformInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetPlatformPluginEnabled(llvm::StringRef name,
+ bool enable) {
+ return GetPlatformInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetProcessPluginInfo() {
+ return GetProcessInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetProcessPluginEnabled(llvm::StringRef name, bool enable) {
+ return GetProcessInstances().SetInstanceEnabled(name, enable);
+}
+
+std::vector<RegisteredPluginInfo> PluginManager::GetREPLPluginInfo() {
+ return GetREPLInstances().GetPluginInfoForAllInstances();
+}
+bool PluginManager::SetREPLPluginEnabled(llvm::StringRef name...
[truncated]
|
dmpots
commented
Jun 12, 2025
| // | ||
| // Plugin Info+Enable Declarations | ||
| // | ||
| static std::vector<RegisteredPluginInfo> GetABIPluginInfo(); |
There was a problem hiding this comment.
I moved all of the declarations to support list/enable/disable to the same location to make it easy to generate the code from a script. I can intersperse these back with their respective plugin locations if desired.
The code was generated with https://gist.github.com/dmpots/caca58fbb45b8c0f63b19553c5402611.
We talked previously about doing a dynamic registration. I poked around a bit in the td file, but nothing obvious jumped out without a bit of work and I wasn't sure it was worth the effort.
I'm happy to discuss alternatives here about how to do the dynamic registration.
| @@ -407,7 +569,7 @@ ABICreateInstance PluginManager::GetABICreateCallbackAtIndex(uint32_t idx) { | |||
| #pragma mark Architecture | |||
|
|
|||
| typedef PluginInstance<ArchitectureCreateInstance> ArchitectureInstance; | |||
| typedef std::vector<ArchitectureInstance> ArchitectureInstances; | |||
| typedef PluginInstances<ArchitectureInstance> ArchitectureInstances; | |||
There was a problem hiding this comment.
The ArchitectureInstance plugins were the only ones using a vector instead of the PluginInstances wrapper. The PluginInstances is need to support enable/disable.
| # CHECK: instrumentation-runtime | ||
| # CHECK: [+] AddressSanitizer AddressSanitizer instrumentation runtime plugin. | ||
| # CHECK: system-runtime |
There was a problem hiding this comment.
This changed because the plugins are now listed alphabetically instead of the order they appear in the source code of PluginManager.h.
There was a problem hiding this comment.
can you add change to using CHECK-DAG: instead of CHECK:? Then things can be out of order. No need to change if the ordering is consistently alphabetized now.
There was a problem hiding this comment.
Switched it to use CHECK-DAG.
clayborg
approved these changes
Jun 13, 2025
| # CHECK: instrumentation-runtime | ||
| # CHECK: [+] AddressSanitizer AddressSanitizer instrumentation runtime plugin. | ||
| # CHECK: system-runtime |
There was a problem hiding this comment.
can you add change to using CHECK-DAG: instead of CHECK:? Then things can be out of order. No need to change if the ordering is consistently alphabetized now.
|
I'll wait a few more days before merging in case someone wants to add more feedback. |
|
No comments, good to merge IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #134418 we added support to list/enable/disable
SystemRuntimeandInstrumentationRuntimeplugins. We limited it to those two plugin typesto flesh out the idea with a smaller change.
This PR adds support for the remaining plugin types. We now support all
the plugins that can be registered directly with the plugin manager.
Plugins that are added by loading shared objects are still not
supported.