Skip to content

[BOLT][NFC] Using target_triple in lit config #144078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

paschalis-mpeis
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jun 13, 2025

@llvm/pr-subscribers-bolt

Author: Paschalis Mpeis (paschalis-mpeis)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/144078.diff

1 Files Affected:

  • (modified) bolt/test/lit.local.cfg (+1-1)
diff --git a/bolt/test/lit.local.cfg b/bolt/test/lit.local.cfg
index d5a6849b27a77..77e19c9f34bad 100644
--- a/bolt/test/lit.local.cfg
+++ b/bolt/test/lit.local.cfg
@@ -1,4 +1,4 @@
-host_linux_triple = config.target_triple.split("-")[0] + "-unknown-linux-gnu"
+host_linux_triple = config.target_triple
 common_linker_flags = "-fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie"
 flags = f"--target={host_linux_triple} -fPIE {common_linker_flags}"
 

@paschalis-mpeis paschalis-mpeis requested a review from aaupov June 13, 2025 15:05
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/simplify-target-triple branch from 525ee97 to 363e651 Compare June 13, 2025 15:07
@paschalis-mpeis
Copy link
Member Author

Hey folks,

Thanks a lot for your input and the reviews. Just checking whether all concerns are now addressed.
If so, I could merge by tomorrow.

@paschalis-mpeis paschalis-mpeis merged commit 41b9d28 into main Jun 17, 2025
7 checks passed
@paschalis-mpeis paschalis-mpeis deleted the users/paschalis-mpeis/simplify-target-triple branch June 17, 2025 06:42
ajaden-codes pushed a commit to Jaddyen/llvm-project that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants