Revert "Turn LIBC_COPT_STRING_UNSAFE_WIDE_READ on by default" #144167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a591bd2.
|
@llvm/pr-subscribers-libc Author: Amy Huang (amykhuang) ChangesReverts llvm/llvm-project#144163 because for some reason I didn't realize there are ASan tests. Full diff: https://github.com/llvm/llvm-project/pull/144167.diff 1 Files Affected:
diff --git a/libc/config/config.json b/libc/config/config.json
index 0354b16997cdd..d53b2936edb07 100644
--- a/libc/config/config.json
+++ b/libc/config/config.json
@@ -59,7 +59,7 @@
},
"string": {
"LIBC_CONF_STRING_UNSAFE_WIDE_READ": {
- "value": true,
+ "value": false,
"doc": "Read more than a byte at a time to perform byte-string operations like strlen."
},
"LIBC_CONF_MEMSET_X86_USE_SOFTWARE_PREFETCHING": {
|
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…44167) Reverts llvm#144163 because for some reason I didn't realize there are ASan tests.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
…44167) Reverts llvm#144163 because for some reason I didn't realize there are ASan tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #144163 because for some reason I didn't realize there are ASan tests.