[Transforms] Add LifetimeMovePass #144319
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jun 16, 2025
|
|
||
| def int_coro_await_suspend_handle : Intrinsic<[], | ||
| [llvm_ptr_ty, llvm_ptr_ty, llvm_ptr_ty], | ||
| [Throws]>; | ||
| [Throws, NoCapture<ArgIndex<0>>]>; |
There was a problem hiding this comment.
This should be a separate change.
There was a problem hiding this comment.
OK. I will separate it before landing this patch. Temporarily keep it so that CI looks good.
Co-authored-by: Nikita Popov <github@npopov.com>
|
(I didn't take a real look yet) We shouldn't put |
NewSigma
changed the title
No. This pass shall not introduce changes to allocation addresses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @ChuanqiXu9 in #143333 , I propose LifetimeMovePass, which was previously part of the CoroSplit pass, should now appear as a general pass. Lifetime markers determine whether we place alloca on the frame or on the stack. By moving these markers to optimized positions, we can reduce the coroutine frame size, leading to significant memory savings.
The LifetimeMovePass is positioned between SimplifyCFG and InstCombine. Currently, it only applies to pre-split coroutines, as I have not yet developed a concrete plan for its interaction with non-coroutine code. This patch is WIP, feel free to share your feedback or suggestions.
Close #49716