Skip to content

[lldb-dap][test] fix not supported error. #144419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

da-viper
Copy link
Contributor

Fixes #144072

buildbot error.

@da-viper da-viper requested a review from JDevlieghere as a code owner June 16, 2025 19:36
@llvmbot llvmbot added the lldb label Jun 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 16, 2025

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

Fixes #144072

buildbot error.


Full diff: https://github.com/llvm/llvm-project/pull/144419.diff

1 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py (+7-1)
diff --git a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
index 51ccf2ccbdcad..05adfb3e342b0 100644
--- a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
+++ b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
@@ -90,7 +90,13 @@ def test_supported_capability_x86_arch(self):
             len(breakpoint_ids), len(bp_lines), "expect correct number of breakpoints"
         )
         self.continue_to_breakpoints(breakpoint_ids)
-        is_supported = self.dap_server.get_capability("supportsStepInTargetsRequest")
+
+        try:
+            is_supported = self.dap_server.get_capability(
+                "supportsStepInTargetsRequest"
+            )
+        except dap_server.NotSupportedError:
+            is_supported = False
 
         self.assertEqual(
             is_supported,

@da-viper
Copy link
Contributor Author

da-viper commented Jun 16, 2025

@JDevlieghere or @ashgti by any chance you have a mac or arm pc to check if this works locally before merging ?

@da-viper da-viper force-pushed the stepintarget-nosupport branch from 22ea9d9 to 31dc0ab Compare June 16, 2025 19:42
@JDevlieghere
Copy link
Member

@JDevlieghere or @ashgti by any chance you have a mac or arm pc to check if this works locally before merging ?

Confirmed locally this makes the test pass 👍

@da-viper da-viper merged commit 34be09a into llvm:main Jun 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants