[libc++] Disabled unexpected_disabled test in modules build #144466
Conversation
This patch disables unexpected_disabled_cpp17.verify.cpp under clang modules builds because it changes diagnostics criteria post llvm#143423, causing the test to fail. This patch follows a similar style to 853059a. This was found when working on trying to land llvm#144033.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesThis patch disables unexpected_disabled_cpp17.verify.cpp under clang modules builds because it changes diagnostics criteria post #143423, causing the test to fail. This patch follows a similar style to This was found when working on trying to land #144033. Full diff: https://github.com/llvm/llvm-project/pull/144466.diff 1 Files Affected:
diff --git a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
index 299cb123fbda3..b92f2baa02e47 100644
--- a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
+++ b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
@@ -8,6 +8,11 @@
// UNSUPPORTED: c++03, c++11, c++14
+// When built with modules, this test gives diagnostics like declaration of
+// 'unexpected' must be imported from module 'std.expected.unexpected' before
+// it is required. Therefore disable it in this configuration.
+// UNSUPPORTED: clang-modules-build
+
// test unexpected
#include <exception>
|
| // When built with modules, this test gives diagnostics like declaration of | ||
| // 'unexpected' must be imported from module 'std.expected.unexpected' before | ||
| // it is required. Therefore disable it in this configuration. | ||
| // UNSUPPORTED: clang-modules-build |
There was a problem hiding this comment.
Doesn't this problem also arise with every other .verify.cpp test we have that checks for the absence of a type or function?
There was a problem hiding this comment.
Just this one and one other that I could find that already has this workaround. This specific diagnostic is done through typo correction so doesn't fire very often.
This patch disables unexpected_disabled_cpp17.verify.cpp under clang modules builds because it changes diagnostics criteria post #143423, causing the test to fail.
This patch follows a similar style to
853059a.
This was found when working on trying to land #144033.