[Flang][OpenMP] Update relevant warnings to emit when OMP >= v5.2 #144492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stylie777
requested review from
tblah,
kiranchandramohan,
Leporacanthicus and
kparzysz
tblah
reviewed
Jun 17, 2025
|
Thanks for the suggestion @tblah, I had avoided doing the version check inside the function to avoid a potentially needed function call, but this approach would be more robust so I will rework the implementation to do this. |
tblah
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
LGTM with nits fixed. Previous discussion was here: #142378 (review)
Edit: see failing test - this does look relevant.
| void IssueNonConformanceWarning( | ||
| llvm::omp::Directive D, parser::CharBlock source); | ||
| void IssueNonConformanceWarning(llvm::omp::Directive D, | ||
| parser::CharBlock source, unsigned emit_from_version); |
There was a problem hiding this comment.
Suggested change
| parser::CharBlock source, unsigned emit_from_version); | |
| parser::CharBlock source, unsigned emitFromVersion); |
| void OmpAttributeVisitor::IssueNonConformanceWarning( | ||
| llvm::omp::Directive D, parser::CharBlock source) { | ||
| void OmpAttributeVisitor::IssueNonConformanceWarning(llvm::omp::Directive D, | ||
| parser::CharBlock source, unsigned emit_from_version) { |
There was a problem hiding this comment.
Suggested change
| parser::CharBlock source, unsigned emit_from_version) { | |
| parser::CharBlock source, unsigned emitFromVersion) { |
There has been a number of deprecation warnings that have been added to Flang, however these features are only deprecated when the OpenMP Version being used is 5.2 or later. Previously, flang did not consider the version with the warnings so would always be emitted. Flang now ensures warnings are emitted for the appropriate version of OpenMP, and tests are updated to reflect this change.
Stylie777
force-pushed
the
deprecation_warnings_omp_5_2
branch
from
23ab4b3 to
2846d90
Compare
|
The test failure is related yes, new test that was added while I was away so this has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a number of deprecation warnings that have been added to Flang, however these features are only deprecated when the OpenMP Version being used is 5.2 or later. Previously, flang did not consider the version with the warnings so would always be emitted.
Flang now ensures warnings are emitted for the appropriate version of OpenMP, and tests are updated to reflect this change.