[compiler-rt] [Fuzzer] Fix ARMv7 test link failure by linking unwinder #144495
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler-rt/lib/fuzzer/tests build was failing on armv7, with undefined references to unwinder symbols, such as __aeabi_unwind_cpp_pr0. This occurs because the test is built with `-nostdlib++` but `libunwind` is not explicitly linked to the final test executable. This patch resolves the issue by adding CMake logic to explicitly link the required unwinder to the fuzzer tests, inspired by the same solution used to fix Scudo build failures by https://reviews.llvm.org/D142888.
luporl
reviewed
Jun 17, 2025
Comment on lines
52
to
53
| else() | ||
| message(FATAL_ERROR "Building fuzzer tests with -nostdlib++ requires a suitable unwinder (libunwind or libgcc_s) but none was found.") |
There was a problem hiding this comment.
Comparing this PR with D142888 I noticed that you have removed this condition:
elseif (NOT COMPILER_RT_USE_BUILTINS_LIBRARY)
In the scudo fix, it was needed by Fuchsia builds.
From what I remember, when COMPILER_RT_USE_BUILTINS_LIBRARY is set, COMPILER_RT_HAS_GCC_S_LIB/COMPILER_RT_HAS_GCC_LIB are not set, as libgcc is not needed.
Is there any reason why this condition is not necessary here?
There was a problem hiding this comment.
ah you are right. I might have missed that by mistake let me fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiler-rt/lib/fuzzer/tests build was failing on armv7, with undefined references to unwinder symbols, such as __aeabi_unwind_cpp_pr0.
This occurs because the test is built with
-nostdlib++butlibunwindis not explicitly linked to the final test executable.This patch resolves the issue by adding CMake logic to explicitly link the required unwinder to the fuzzer tests, inspired by the same solution used to fix Scudo build failures by https://reviews.llvm.org/D142888.