[SLP] vectorizeStores: Name things a bit more clearly (NFC) #144511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the new variable names better convey their purpose. However, I also believe that function is more complex than it needs to be, and this tiny patch should be seen as a first step towards (maybe) further refactoring. The previous names were very generic (Size, Sz, Cnt, StartIdx). This made it easy to get confused given that the vecotrizeStores() function is already complex enough. My hope would be to eventually have a function concise enough to clearly see what are the different strategies being attempted to vectorise a group of related store instructions.
sdesmalen-arm
approved these changes
Jun 17, 2025
alexey-bataev
approved these changes
Jun 17, 2025
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 17, 2025
) I believe the new variable names better convey their purpose. However, I also believe that function is more complex than it needs to be, and this tiny patch should be seen as a first step towards (maybe) further refactoring. The previous names were very generic (Size, Sz, Cnt, StartIdx). This made it easy to get confused given that the vecotrizeStores() function is already complex enough. My hope would be to eventually have a function concise enough to clearly see what are the different strategies being attempted to vectorise a group of related store instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the new variable names better convey their purpose. However, I also believe that function is more complex than it needs to be, and this tiny patch should be seen as a first step towards (maybe) further refactoring.
The previous names were very generic (Size, Sz, Cnt, StartIdx). This made it easy to get confused given that the vecotrizeStores() function is already complex enough.
My hope would be to eventually have a function concise enough to clearly see what are the different strategies being attempted to vectorise a group of related store instructions.