Skip to content

[CIR][NFCI] Represent Complex RValues As Single Value #144519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

mmha
Copy link
Contributor

@mmha mmha commented Jun 17, 2025

This patch removes one mlir::Value in the RValue class that has been used to represent complex values in classic CG. In CIR we plan on representing complex as a single value. It also removes some now unnecessary member functions related to complex handling.

This patch removes one mlir::Value in the RValue class that has been
used to represent complex values in classic CG. In CIR we plan on
representing complex as a single value. It also removes some now
unnecessary member functions related to complex handling.
Copy link
Member

@AmrDeveloper AmrDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mmha mmha merged commit ed07b54 into llvm:main Jun 17, 2025
8 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jun 18, 2025

LLVM Buildbot has detected a new failure on builder clang-arm64-windows-msvc running on linaro-armv8-windows-msvc-04 while building clang at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/6612

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Testing/Support/./TestingSupportTests.exe/0/3' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\unittests\Testing\Support\.\TestingSupportTests.exe-LLVM-Unit-11216-0-3.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=3 GTEST_SHARD_INDEX=0 C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\unittests\Testing\Support\.\TestingSupportTests.exe
--

Script:
--
C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\unittests\Testing\Support\.\TestingSupportTests.exe --gtest_filter=TempPathTest.TempDir
--
C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/llvm-project/llvm/unittests/Testing/Support/TempPathTest.cpp(40): error: Value of: sys::fs::exists(Path)
  Actual: true
Expected: false


C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/llvm-project/llvm/unittests/Testing/Support/TempPathTest.cpp:40
Value of: sys::fs::exists(Path)
  Actual: true
Expected: false



********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants