Skip to content

[RISCV] Add patterns for generating QC_CTO and QC_CLO #144532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

svs-quic
Copy link
Contributor

@svs-quic svs-quic commented Jun 17, 2025

These instructions count leading/trailing ones in the register.

Currently these are only generated when we have Zbb enabled (along with Xqcibm) since it contains the CTTZ/CTLZ instructions.

Copy link
Member

@lenary lenary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hchandel hchandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenary
Copy link
Member

lenary commented Jun 17, 2025

Can you add a note to the commit message saying that for pattern coverage reasons, these patterns are only added when you also have Zbb (which contains ctz/clz)

@svs-quic
Copy link
Contributor Author

Can you add a note to the commit message saying that for pattern coverage reasons, these patterns are only added when you also have Zbb (which contains ctz/clz)

Done.

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svs-quic svs-quic merged commit a2ad656 into llvm:main Jun 18, 2025
8 checks passed
@svs-quic svs-quic deleted the xqci_clo_gen branch June 18, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants