[lldb/cmake][WIP] Plugin layering enforcement mechanism #144543
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not completely finished (not least because it doesn't build), but I think the framework is obvious, so I though this would be a good idea for the first round of feedback. (context: #139170) |
|
As I needed to make sense of these deps, I made the code generate a dependency graph (yay for cmake). This is what it looks like right now:
|
labath
commented
Jun 17, 2025
Comment on lines
+3
to
+4
| define_property(DIRECTORY PROPERTY LLDB_PERMITTED_PLUGIN_DEPENDENCIES) | ||
| define_property(TARGET PROPERTY LLDB_PERMITTED_PLUGIN_DEPENDENCIES INHERITED) |
There was a problem hiding this comment.
I suppose one question is whether to create separate categories for "permitted" (okay) and "tolerated" (things we'd rather remove, shown as yellow in the graph) dependencies...
There was a problem hiding this comment.
Seems like a nice to have as it makes it easy to track the progress towards our ultimate goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.