Skip to content

[Remarks] Auto-detect remark parser format #144554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: users/tobias-stadler/remark-infra-autodetect-base
Choose a base branch
from

Conversation

tobias-stadler
Copy link
Contributor

Add remark format 'Auto', which performs automatic detection of the remark format using the magic numbers at the beginning of the remarks files.

The RemarkLinker already did something similar, so we streamlined this and exposed this to llvm-remarkutil.

Depends on #144527

Add remark format 'Auto', which performs automatic detection of the
remark format using the magic numbers at the beginning of the remarks
files.

The RemarkLinker already did something similar, so we streamlined this
and exposed this to llvm-remarkutil.

Depends on llvm#144527
Copy link
Contributor

@jroelofs jroelofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants