[ORC] Fix synchronization in CoreAPIsTest. #144556
Open
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code previously appeared to have a (benign?) race condition on `WorkThreads.size`, since it was being accessed outside of the mutex lock that protected it on the threads. This is usually okay since 1a1d6e6, but doesn't seem reliable in general, so fix this code to express the intent more accurately. This relies on the same general principles as ref-counting, where each existing reference (thread) can add new references (threads) because they already have a reference themselves (until joined).
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
lhames
approved these changes
Jun 18, 2025
| std::vector<std::thread> WorkThreads; | ||
| SmallVector<std::thread,0> WorkThreads; |
There was a problem hiding this comment.
Is this change in vector type necessary? If not it'd be better to leave out.
Comment on lines
-1565
to
+1564
| std::lock_guard<std::mutex> Lock(WorkThreadsMutex); | ||
| std::unique_lock Lock(WorkThreadsMutex); |
There was a problem hiding this comment.
I think this could remain a lock_guard, since manual locking/unlocking isn't needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously appeared to have a (benign?) race condition on
WorkThreads.size, since it was being accessed outside of the mutex lock that protected it on the threads. This is usually okay since 1a1d6e6, but doesn't seem reliable in general, so fix this code to express the intent more accurately. This instead relies on the same general principles as ref-counting, where each existing reference (thread) can add new references (threads) because they already have a reference themselves (until joined).