Skip to content

feature: Unify and enhance logging system, add log viewer, and improve in-game debugger #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

kirre-bylund
Copy link
Contributor

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies and enhances the logging system, adds an in-game log viewer, and improves the in-game debugger.

  • Introduces HTTP log recording and playback in the logger.
  • Adds UI components (UXML/USS) for a dedicated log viewer window in the Unity Editor.
  • Integrates log viewer actions into the admin extension UI and adjusts HTTP client logging.

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Runtime/Game/LootLockerLogger.cs Added HTTP log recording, backlog replay logic, and new HTTP log listener interface.
Runtime/Editor/LogViewer/* New UXML, USS, and C# files to implement the Log Viewer window and its UI.
Runtime/Editor/Editor UI/LootLockerAdminExtension.* Integrated a new Log Viewer button into the admin extension UI.
Runtime/Client/LootLockerHTTPClient.cs Updated HTTP client logging to use the new HTTP log system and cleaned up some deprecated logging calls.
Prefabs/Debugging/LootLockerDebuggerPrefab.unitypackage.meta Updated metadata for the debugging prefab.
Comments suppressed due to low confidence (1)

Runtime/Game/LootLockerLogger.cs:158

  • [nitpick] Add a comment to explain the ordering logic used to replay log records from a circular buffer to improve code clarity and future maintainability.
            List<LogRecord> backlog = new List<LogRecord>();

@kirre-bylund kirre-bylund force-pushed the feature/admin-extension-improvements branch from ff7294d to b44918d Compare June 23, 2025 08:18
Base automatically changed from feature/admin-extension-improvements to dev June 23, 2025 19:47
@kirre-bylund kirre-bylund merged commit c1a4db3 into dev Jun 24, 2025
83 of 85 checks passed
@kirre-bylund kirre-bylund deleted the feature/log-viewer branch June 24, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant