Skip to content

Updates to the HTMLDialogElement.returnValue example #39340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

wbamberg
Copy link
Collaborator

This makes some updates to the example for https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/returnValue.

It's mostly motivated by some of the issues discussed in #39336. I also made a few other changes though:

  • updated the description for clarity
  • separated HTML and JavaScript
  • added subheadings
  • some minor code updates, like using the ternary operator and template strings, and more consistent naming.

@wbamberg wbamberg requested a review from a team as a code owner April 30, 2025 17:45
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team April 30, 2025 17:45
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 30, 2025
Copy link
Contributor

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/API/HTMLDialogElement/returnValue
Title: HTMLDialogElement: returnValue property
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect

@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Apr 30, 2025
@wbamberg wbamberg changed the title Updates to the dialog returnValue example Updates to the HTMLDialogElement.returnValue example Apr 30, 2025
@sideshowbarker sideshowbarker merged commit 892f5d7 into mdn:main May 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants