-
Notifications
You must be signed in to change notification settings - Fork 23k
Fix element ID #39909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix element ID #39909
Conversation
…ml canvas element id The canvas element id is 'tutorial'. But the simple example is doing a get element by id of 'canvas' Changing the get element by id to 'tutorial' will allow the simple example to run and draw the two intersecting rectangles.
|
Preview URLs (comment last updated: 2025-06-12 16:42:41) |
|
Thanks for filing! This is a regression introduced in #39757, which changed the The only issue I have with this PR is that this page is part of a series, which follow the same pattern (see e.g. the example in https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors#a_fillstyle_example) and it would be good for them all to use the same I don't know if you want to extend this PR to update all the other pages in this tutorial If you don't I'll just merge this and take care of the others :). |
|
Apparently, this is the only page that uses |
|
Looks good to me thanks Josh and wbamberg |
The reason I didn't suggest that was that #39757 changed the |
|
The reason was because the init template before that used |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you!
…ml canvas element id
The canvas element id is 'tutorial'.
But the simple example is doing a get element by id of 'canvas' Changing the get element by id to 'tutorial' will allow the simple example to run and draw the two intersecting rectangles.
Description
The canvas element id is 'tutorial'.
But the simple example is doing a get element by id of 'canvas' Changing the get element by id to 'tutorial' will allow the simple example to run and draw the two intersecting rectangles.
Motivation
Currently the simple example does not run because the canvas element id does not match the javascript simple example.
Additional details
Related issues and pull requests