Simplify construction of Python Consortium object
#7065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual - this isn't what I started today doing, but it became a stumbling block for something else so seemed worth cleaning up.
This is an instance where we pass some very custom objects for very specific behaviour a few layers down, even though we have exactly 2 calling points! Scrap that - lots of people want to add
Members after aConsortiumhas been constructed, initial members aren't special. There's still a little bit of threading in-and-out of aConsortiumobject for access to default values and script paths etc, but at least it's named now?Let's see what breaks.