Skip to content

Commit 1a75a30

Browse files
authored
Don't pass through to DXIL.dll in DxcCreateInstance for CLSID_DxcValidator (#7409)
This change removes the code meant to pass through to DXIL.dll when creating a CLSID_DxcValidator object with DxcCreateInstance. Since the internal validator is now the default, and it will sign shaders, there is no reason to pass through to DXIL.dll when using DxcCreateInstance on DxCompiler.dll. Testing will come with planned work to include the ability to globally override the default validator to external.
1 parent 6d67e4a commit 1a75a30

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

tools/clang/tools/dxcompiler/dxcapi.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,7 @@ static HRESULT ThreadMallocDxcCreateInstance(REFCLSID rclsid, REFIID riid,
8787
} else if (IsEqualCLSID(rclsid, CLSID_DxcUtils)) {
8888
hr = CreateDxcUtils(riid, ppv);
8989
} else if (IsEqualCLSID(rclsid, CLSID_DxcValidator)) {
90-
if (DxilLibIsEnabled()) {
91-
hr = DxilLibCreateInstance(rclsid, riid, (IUnknown **)ppv);
92-
} else {
93-
hr = CreateDxcValidator(riid, ppv);
94-
}
90+
hr = CreateDxcValidator(riid, ppv);
9591
} else if (IsEqualCLSID(rclsid, CLSID_DxcAssembler)) {
9692
hr = CreateDxcAssembler(riid, ppv);
9793
} else if (IsEqualCLSID(rclsid, CLSID_DxcOptimizer)) {

0 commit comments

Comments
 (0)