Skip to content

[Validation] Test validation behavior and add validation testing infrastructure #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bob80905 opened this issue Apr 29, 2025 · 2 comments
Assignees
Labels
enhancement Feature suggestion needs-triage Awaiting triage

Comments

@bob80905
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, there does not exist an adequate infrastructure to test the validator that is chosen when validating a shader.
A user can manually test which validation version is used when validating a shader, but there's no automated way within the DXC repo to do this testing.

Describe the solution you'd like
Testing infrastructure should be added to the DXC repo to validate that the right validator is being used in all of the following 3 cases:
-select-validator internal
-select-validator external
<no option, aka default behavior>

One approach is to add an environment variable that will point to a DXIL.dll to use for validation, if -select-validator external is specified. Then, a set of versioned DXIL.dlls can be added to the DXC repo, and a testing suite can be created with an environment variable that points to each of the stored DXIL.dlls. This way we can validate that the external option indeed selects the right validator.
The design should conform to the behavior described in https://github.com/microsoft/hlsl-specs/blob/main/proposals/infra/INF-0004-validator-hashing.md

@damyanp
Copy link
Member

damyanp commented May 1, 2025

#7397

@damyanp
Copy link
Member

damyanp commented May 2, 2025

This proposal describes a plan to address this: microsoft/hlsl-specs#499

@bob80905 bob80905 self-assigned this May 2, 2025
@bob80905 bob80905 moved this to Active in HLSL Support May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature suggestion needs-triage Awaiting triage
Projects
Status: No status
Development

No branches or pull requests

2 participants