-
Notifications
You must be signed in to change notification settings - Fork 760
Implement HLSL Diagnostics for LinAlg operations #7430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HLSL Diagnostics for LinAlg operations #7430
Conversation
tools/clang/test/SemaHLSL/hlsl/linalg/builtins/mul_add_invalid.hlsl
Outdated
Show resolved
Hide resolved
Couple of items left to do here:
|
@anupamachandra - given that there's build errors and you have some more work planned, is it worth reviewing at this point? |
Yes please. I'm working on the build errors and missed item is marked with a //FIXME. It think it'll be good to get some eyes on it to check if the PR meets expectations in terms of scope and if any big issues/gaps stand out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits / questions
tools/clang/test/SemaHLSL/hlsl/linalg/builtins/mul_add_invalid.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/SemaHLSL/hlsl/linalg/builtins/outer_product_accumulate_invalid.hlsl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments on linalg.h
API changes.
…ocalization issues
…g component class and update tests
✅ With the latest revision this PR passed the Python code formatter. |
This PR implements checks to validate the linalg builtin functions: __builtin_MatVecMul, __builtin_MatVecMulAdd, __builtin_OuterProductAccumulate and __builtin_VectorAccumulate. This includes:
Adds tests for all the above error checks.
Implements #7336