Skip to content

Long Vector Execution tests preliminary work to merge a minor refactor. #7532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025

Conversation

alsepkow
Copy link
Contributor

This resolves issue #7531. This is a preliminary step to merging in some of the Long Vector Execution tests currently sitting in the staging-sm6.9 branch. There are no functional changes here, but given that this is a refactor I do not want to add the [NFC] tag to the PR title.

  • Moves functions used by existing exec tests and incoming long vector tests to a common HlslExecTestUtils.h.
  • Updates naming to adhere to LLVM coding standards for newly created files (even though the functions aren't new)
  • Move a few other shared functions to files that make more sense than ExecutionTest.cpp.
  • TableParameterHandler class moved to its own header/cpp files. No naming updates as nothing else was touched. Can update in a subsequent PR if it is preferred.
  • Add the LLVM coding guidelines preferred include guard to HlslTestUtils.h to mitigate redefinition issues exposed by this refactor.
  • Updated the D3D shader model 'redefines' in ExecutionTest.cpp as they were also factored out into a common header. constexpr required because they are enum values.
  • BigObj added to the cmake file as I was hitting issues locally for this.

Copy link
Contributor

github-actions bot commented Jun 12, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Collaborator

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question, this LGTM

@alsepkow alsepkow merged commit f94396d into microsoft:main Jun 16, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants