[NFC] Address compiler warnings: Fix C4146 compiler warnings in APInt.cpp #7556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsepkow
changed the title
bob80905
approved these changes
Jun 19, 2025
inbelic
approved these changes
Jun 19, 2025
| // it evaluates to the same bit pattern as INT64_MIN. Because N is | ||
| // unsigned, assigning N = ~I + 1 preserves the exact bit pattern | ||
| // and correctly represents the 2's complement value of -I. | ||
| N = (~I + 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7555
All but one are simple updates to use std::numeric_limits.
One case converts to use ~ operator and includes a comment with additional context.