[NFC] Address compiler warnings: C4146 - Another round of use two's complement instead of negation #7567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
approved these changes
Jun 21, 2025
alsepkow
changed the title
tex3d
approved these changes
Jun 25, 2025
|
Agree, I started to question that as I was changing more. Think its worth doing an update when all the fixes are checked in to swap to a utility function? It would definitely improve readability. And allow for a localized comment on the logic/quirks.
When I was initially making these changes I was operating on the assumption that the changes should be minimal. For some reason that made me feel like adding a utility function would violate that. But I think it would actually do the opposite!
…________________________________
From: Tex Riddell ***@***.***>
Sent: Tuesday, June 24, 2025 5:33 PM
To: microsoft/DirectXShaderCompiler ***@***.***>
Cc: Alex Sepkowski ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DirectXShaderCompiler] [NFC] Address compiler warnings: C4146 - Another round of use two's complement instead of negation (PR #7567)
@tex3d approved this pull request.
I feel like there should be an overloaded utility function for this common pattern of "negate unsigned value".
—
Reply to this email directly, view it on GitHub<#7567 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABK4EW46CVZ4M7YHQXOPQ6T3FHU6ZAVCNFSM6AAAAAB7ZPHORGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNJVHAZDCNJYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7565
A few more instances where we can take advantage of -N being equivalent to (~N + 1)