Skip to content

Cell height not consistent #18858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vefatica opened this issue May 1, 2025 · 7 comments
Closed

Cell height not consistent #18858

vefatica opened this issue May 1, 2025 · 7 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@vefatica
Copy link

vefatica commented May 1, 2025

Here are the settings for my default profile (first) and another similar profile.

Image

Image

And here are the two, in action, side by side (default profile on the left with the preferred appearance).

Image

Why is the line spacing different?

FWIW, here are the two JSON entries.

            {
                "bellStyle": 
                [
                    "audible",
                    "window"
                ],
                "closeOnExit": "always",
                "colorScheme": "Campbell",
                "commandline": "d:\\tc34\\tcc.exe",
                "cursorHeight": 15,
                "font": 
                {
                    "face": "Consolas",
                    "size": 13
                },
                "guid": "{4f4f6c96-a91f-45dc-9757-4d7e40f053e4}",
                "hidden": false,
                "icon": "u:\\icons\\tccicon1.ico",
                "name": "TCC34",
                "scrollbarState": "visible",
                "startingDirectory": "v:\\",
                "tabTitle": null
            },
            {
                "bellStyle": 
                [
                    "audible",
                    "window"
                ],
                "closeOnExit": "always",
                "colorScheme": "Campbell",
                "commandline": "d:\\tc35\\tcc.exe",
                "cursorHeight": 15,
                "cursorShape": "vintage",
                "font": 
                {
                    "cellHeight": "1.2",
                    "cellWidth": "0.6",
                    "face": "Consolas",
                    "size": 13,
                    "weight": "normal"
                },
                "guid": "{5486a1c5-a6ca-4b38-a69f-c1752ebc5a69}",
                "hidden": false,
                "icon": "U:\\Icons\\tcmd.ico",
                "name": "TCC35",
                "scrollbarState": "visible",
                "startingDirectory": "v:\\",
                "tabTitle": null
            },

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 1, 2025
@DHowett
Copy link
Member

DHowett commented May 1, 2025

You set a cellHeight on one of them...

@DHowett
Copy link
Member

DHowett commented May 1, 2025

The default of 1.2 is "roughly" correct. It is not always correct for all fonts. It is a best guess. :)

@vefatica
Copy link
Author

vefatica commented May 1, 2025

Yes I did. I recently messed with those numbers (in Settings) for the TCC35 profile and then set them to match the TCC34 profile. Are you saying that if the 1.2 shows in Settings but not in the JSON file, it may not be exactly what I get?

@DHowett
Copy link
Member

DHowett commented May 1, 2025

Er. I had assumed you set 1.2 based on the explanation in the settings page about how it's generally roughly that value for most fonts.

If you want to return to the actual default value, just delete it from your settings file or click the ↩️ button.

It may still say "1.2" in the settings, but the explanation should explain that. That's just a placeholder value.

@DHowett
Copy link
Member

DHowett commented May 7, 2025

Gonna close this one out as it seems resolved. Let us know if that's not the case! Thanks!

@DHowett DHowett closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2025
@vefatica
Copy link
Author

vefatica commented May 7, 2025

It's not very important but can't the actual value in use be shown in the settings?

@DHowett
Copy link
Member

DHowett commented May 7, 2025

No. We aren't going to crack the font and re-derive those values (PER DISPLAY) just to show an accurate placeholder.

If you want the actual value to be used, leave it unset. If you want the actual value to be seen, derive it for your own display DPI, screen size, font size and font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants
@DHowett @vefatica and others