[GR-64787] Enable --install-exit-handlers by default and deprecate the option. #11149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
vj/GR-64787-install-exit-handlers-by-default
branch
5 times, most recently
from
eeab102 to
44fb8aa
Compare
zakkak
reviewed
May 12, 2025
There was a problem hiding this comment.
Hi @vjovanov , Quarkus is already setting up its own signal handlers so we would like to have the option to disable this (at least for some transition period). Is it safe to assume -H:-InstallExitHandlers will survive at least till GraalVM for JDK 29? Thanks.
|
|
||
| @APIOption(name = "install-exit-handlers", deprecated = "Enabled by default for executables. For shared libraries (when --shared is used), use the experimental option -H:+InstallJavaExitHandlersForSharedLibrary.")// | ||
| @Option(help = "Provide java.lang.Terminator exit handlers", deprecated = true, deprecationMessage = "Enabled by default for executables. For shared libraries (when --shared is used), use the experimental option -H:+InstallJavaExitHandlersForSharedLibrary.")// | ||
| protected static final HostedOptionKey<Boolean> InstallExitHandlers = new HostedOptionKey<>(false); |
There was a problem hiding this comment.
Shouldn't this be true?
Suggested change
| protected static final HostedOptionKey<Boolean> InstallExitHandlers = new HostedOptionKey<>(false); | |
| protected static final HostedOptionKey<Boolean> InstallExitHandlers = new HostedOptionKey<>(true); |
graalvmbot
force-pushed
the
vj/GR-64787-install-exit-handlers-by-default
branch
5 times, most recently
from
61e8e67 to
65ad0eb
Compare
zakkak
approved these changes
May 22, 2025
I did some testing and it looks like Quarkus can still override the signal handlers installed by GraalVM so this is not an issue after all, although it might still make sense to keep around for other users. Sorry for the noise. |
graalvmbot
force-pushed
the
vj/GR-64787-install-exit-handlers-by-default
branch
5 times, most recently
from
6979770 to
d9fbd00
Compare
graalvmbot
changed the title
Enable `--install-exit-handlers` by default and deprecate the option. Image size increase is negligable (10 types with 53 mehtods), and there is only 2.5% extra starup instructions (68498) for "Hello, World!" on Linux. If shared libraries were using this flag, the same functionality can be restored by using `-H:+InstallJavaExitHandlersForSharedLibrary`.
graalvmbot
force-pushed
the
vj/GR-64787-install-exit-handlers-by-default
branch
from
d9fbd00 to
38f70ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
--install-exit-handlersby default and deprecate the option.Image size increase is negligible (10 new types and 53 new methods), and there is only 2.5% extra startup instructions (68498) for "Hello, World!" on Linux.