fix(config): handle null from yaml_parse_file in Yaml adapter #16776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Fixed - Fixed `Phalcon\Config\Adapter\Yaml` constructor to handle `null` return values from `yaml_parse_file()`, ensuring empty configuration files are treated as empty arrays instead of throwing errors.
### Added - Added a unit test to verify that empty YAML files are handled correctly and return an empty config array instead of causing errors.
empty config file
niden
requested changes
Jun 23, 2025
|
Also an entry in the CHANGELOG for this change please. |
|
And it seems you need to run Check the Github Actions for where the issues are Thanks |
niden
approved these changes
Jun 23, 2025
|
Thank you @ucando |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential bug in
Phalcon\Config\Adapter\Yamlwhereyaml_parse_file()may returnnullwhen parsing an empty YAML file. Without proper handling, this could result in anullvalue being passed to the parent constructor, leading to unexpected errors.Changes
nullcheck in the constructor ofYamladapter and fallback to an empty array.configAdapterYamlConstructHandlesEmptyYaml) to ensure that empty YAML files return an empty configuration array without throwing an exception.tests/_data/assets/config/empty.ymlas a test fixture file.