You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even though the finalScoreAnimation property is recognized as a TweenChain but the remove() method is typed as BaseTween.remove(). This might be an issue with how the tsgen script handles overrides.
When thinking about it a little more, the change from a 0 argument method to a 1 argument method in the child class doesn't really comply with the Liskov Substitution Principle (it doesn't event have the same effect). Maybe renaming this method to something like removeTween() would make more sense?
The text was updated successfully, but these errors were encountered:
When using the
TweenChain.remove()
method with an argument, the TypeScript compiler issues an error:Even though the
finalScoreAnimation
property is recognized as aTweenChain
but theremove()
method is typed asBaseTween.remove()
. This might be an issue with how the tsgen script handles overrides.phaser/src/tweens/tween/TweenChain.js
Line 155 in c62baca
When thinking about it a little more, the change from a 0 argument method to a 1 argument method in the child class doesn't really comply with the Liskov Substitution Principle (it doesn't event have the same effect). Maybe renaming this method to something like
removeTween()
would make more sense?The text was updated successfully, but these errors were encountered: