-
Notifications
You must be signed in to change notification settings - Fork 64
feat(tsserver plugins): Allow for path in tsserver_plugins #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ci failed due to |
could we get this merged? It is critical for NixOS users. |
Shouldn't there also be a way to specify specific languages/filetypes for each plugin? Like the lspconfig docs include this to enable the vue plugins for ts_ls init_options = {
plugins = {
{
name = "@vue/typescript-plugin",
location = "/usr/local/lib/node_modules/@vue/typescript-plugin",
languages = {"javascript", "typescript", "vue"},
},
},
}, |
you are right, this is way more better. and i think it should be added into doc, some people like me didn't know we can even did it like this🥲 |
@Parsifa1 This PR seems to be valid, what's the reason for closing? I think that the project would benefit from it even if the same things can be configured through lspconfig. |
@wvffle I misunderstood what he meant. I thought TypeScript-tools already had the |
It's been over a month, but this feature still hasn’t been merged. Just wanted to point out that this is really useful for nvm users—they wouldn’t have to depend on a specific npm version and could just install plugins anywhere (e.g., using Mason for the Vue plugin). I’d rather not keep reinstalling global packages just for updating latest npm or change project directory. Just wanted to share my thoughts—hope this feature available soon! |
I've been daily driving this PR since February and it works fine. Could we get this merged? |
Is there a reason this isn't getting merged? If you point out the issues, we can work on it @pmizio |
It seems like @KostkaBrukowa is responsible for maintaining this repository. Could we get this merged? |
maybe closed #287
what i did
add a another way to add
tsserver_plugins
:and can be mixed with string.
example: