Skip to content

Icon support #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Icon support #38

wants to merge 3 commits into from

Conversation

pvsr
Copy link
Owner

@pvsr pvsr commented Jan 23, 2024

No description provided.

@@ -21,6 +20,7 @@ def creator_options(f: Callable[..., Any]) -> Callable[..., Any]:
is_flag=True,
help="If --launch is set, run qutebrowser in the foreground.",
),
# TODO --no-icon?
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I want to make a network connection by default without asking. Maybe --icon should be explicitly required.


prompt = "-p qutebrowser"
command = menu
# TODO arg
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this was

@@ -114,7 +83,10 @@ def new_profile(
) -> bool:
if create_profile(profile, overwrite):
create_config(profile, home_page, overwrite)
if home_page:
# TODO catch errors?
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should

@pvsr pvsr force-pushed the icons branch 2 times, most recently from 826a96b to 5964288 Compare January 23, 2024 06:09
@pvsr pvsr force-pushed the icons branch 2 times, most recently from 3635d7d to 653d73e Compare June 30, 2024 06:28
wip vendor/rewrite favicon dep

update PKGBUILD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant