-
Notifications
You must be signed in to change notification settings - Fork 2
Icon support #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Icon support #38
Conversation
@@ -21,6 +20,7 @@ def creator_options(f: Callable[..., Any]) -> Callable[..., Any]: | |||
is_flag=True, | |||
help="If --launch is set, run qutebrowser in the foreground.", | |||
), | |||
# TODO --no-icon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I want to make a network connection by default without asking. Maybe --icon
should be explicitly required.
|
||
prompt = "-p qutebrowser" | ||
command = menu | ||
# TODO arg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this was
@@ -114,7 +83,10 @@ def new_profile( | |||
) -> bool: | |||
if create_profile(profile, overwrite): | |||
create_config(profile, home_page, overwrite) | |||
if home_page: | |||
# TODO catch errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should
826a96b
to
5964288
Compare
3635d7d
to
653d73e
Compare
wip vendor/rewrite favicon dep update PKGBUILD
No description provided.