support creating index on update if missing #5773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
approved these changes
May 21, 2025
Comment on lines
+296
to
+298
| fn update_index_qp() -> impl Filter<Extract = (UpdateQueryParams,), Error = Rejection> + Clone { | ||
| serde_qs::warp::query::<UpdateQueryParams>(serde_qs::Config::default()) | ||
| } |
There was a problem hiding this comment.
It's ok to inline this this given the function signature is longer than its content 😄
There was a problem hiding this comment.
yeah but calling that function is imo easier to read (and shorter) than the whole serde_qs line would be if it was copied to the callsite
i can inline if you prefer, but i personally don't
There was a problem hiding this comment.
No strong opinion. It is usually inlined in the rest of the codebase (e.g ingest_filter, search filters), but not always (extract_format_from_qs).
Comment on lines
+124
to
+147
| sandbox | ||
| .rest_client(QuickwitService::Indexer) | ||
| .indexes() | ||
| .update( | ||
| "my-updatable-index", | ||
| r#" | ||
| version: 0.8 | ||
| index_id: my-updatable-index | ||
| doc_mapping: | ||
| field_mappings: | ||
| - name: title | ||
| type: text | ||
| - name: body | ||
| type: text | ||
| indexing_settings: | ||
| commit_timeout_secs: 1 | ||
| search_settings: | ||
| default_search_fields: [title, body] | ||
| "#, | ||
| quickwit_config::ConfigFormat::Yaml, | ||
| true, | ||
| ) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
nit, I think PUT is supposed to return 201 if the ressource was created
|
@trinity-1686a Could you also update the docs? |
rdettai
approved these changes
Jun 5, 2025
quickwit/quickwit-integration-tests/src/tests/update_tests/create_on_update.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when sending an index update, optionally create the index if it didn't exist previously
for coherency, we could support that feature for sources too, this isn't implemented
How was this PR tested?
manually tested, added tests