Add min_shards parameter to index config
#5781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If idle shards are an expensive thing to keep, I don't think it a bad thing if it goes below. Especially once the finalized runs after data stops flowing. The initial create is kind of the bigger win. In our case at least |
quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs
Outdated
Show resolved
Hide resolved
fulmicoton-dd
approved these changes
Jun 2, 2025
rdettai
reviewed
Jun 2, 2025
guilload
force-pushed
the
guilload/min-shards
branch
2 times, most recently
from
a96b726 to
ceddfb1
Compare
guilload
force-pushed
the
guilload/min-shards
branch
from
ceddfb1 to
5a482f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
min_shardsparameter to index config. When the control place receives anGetOrCreateOpenShardsrequest, it opensmin_shardsshards instead of 1. When scaling down, it ensures that we do not scale down belowmin_shards. When scaling up, it ensures that there is at leastmin_shardsopen if the index is actively receiving data (not idling).How was this PR tested?
Added unit tests