Skip to content

Cleanup decorator tests #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2023
Merged

Cleanup decorator tests #221

merged 2 commits into from
May 10, 2023

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented May 7, 2023

Remove decorator nodes 20abe87 and
format tests with tree-sitter test --update f41ba3e

@nkrkv
Copy link
Collaborator

nkrkv commented May 10, 2023

Thanks a lot!

Also, if you have an idea on how to prevent committing non-formatted tests on the CI level (so that your goodwill is enforced), I would much appreciate such a PR. I see it as trying tree-sitter test --update and checking if there were some changes or not.

@nkrkv nkrkv merged commit 6c4438c into rescript-lang:main May 10, 2023
@aspeddro
Copy link
Collaborator Author

The command tree-sitter test --update update files tests with current parse output. It's not actually a formatter.

What I did was this:

  • Remove an expression_statement
  • Run tree-sitter test --update, then the entire file is formatted.
  • Add the previously removed expression_statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants