[metacling] Use InterOps JitCall for default object construction #18546
Conversation
Test Results 20 files 20 suites 3d 5h 10m 27s ⏱️ Results for commit 195a654. ♻️ This comment has been updated with latest results. |
aaronj0
force-pushed
the
tcling-jitcall
branch
3 times, most recently
from
1234a90 to
0ffa579
Compare
aaronj0
force-pushed
the
tcling-jitcall
branch
8 times, most recently
from
80b6267 to
a6104c6
Compare
|
@smuzaffar we believe these changes would benefit from a CMSSW CI run, could you help us with that? |
|
@vepadulano , cmssw ci tests are running via cms-sw#225 |
|
Hi @smuzaffar @vepadulano, Aaron and me can't see the build logs behind the CMS login. Can one of you CMS guys please check the logs and see if the failures are related, copy-pasting relevant error messages if there are any? Thanks! |
|
cmssw CI tests look good. The unit tests failure are not due to this change. cms-sw/cmssw#48393 should fix those tests (#19096 : Root's removal of deprecated _TDirectory_getattr pythonization) |
aaronj0
changed the title
|
@smuzaffar can we give another try of this pr in cmssw? |
aaronj0
force-pushed
the
tcling-jitcall
branch
2 times, most recently
from
4298e72 to
2839d14
Compare
restarted cmssw ci tests |
Adds various upstreamed developments: compiler-research/CppInterOp#650 streamlines the logic in Cpp::Construct to be more generic. compiler-research/CppInterOp#643 by @hageboeck making CppInterOp work with new gtest target names Fixed wrapper name conflicts with ROOT that also uses `__cf`, allowing us to integrate JitCall incrementally and co-exist with CallFunc Fixes related to the cppyy forks Unrelated work on Emscripten and WebAssembly
This PR drops the constructor wrapper generation for default ctors in CallFunc (
TClingCallFunc::ExecDefaultConstructor) and now uses CppInterOps JitCall facility. This move improves the generated wrappers, provides a safe interface for construction, gives us better diagnostics and is a well-tested interface (SeeCpp::Construct) that can eventually be upstreamed to LLVM