-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] use cmake for several io tests #19169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use different file names inside to let run tests in parallel Mark methods as override
Use override syntax
Was not tested, source code Event.cxx was not exists Trying to adopt code from io/event fails
Major tests was failing already with Makefile - mark them so also in cmake Provide also ref file for printLittle macro, it works normally
Test Results 20 files 20 suites 3d 14h 43m 42s ⏱️ Results for commit d47a19f. ♻️ This comment has been updated with latest results. |
One of the windows failures contains:
which is likely to be cause by one of (c)test triggering a full rebuild of ROOT. |
@pcanal do you think this is ready for approval? The Win failure seemed to be spurious... |
Last CI run was without failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
root/io/directory
- use unique file names to let run tests in parallelroot/io/emulated
- useROOTEXE_OPTS
to load pre-compiled headersroot/io/event01
- delete completely, not compiled, missing source files,root/io/fakeClass
- several tests marked asWILLFAIL
, same as in Makefile