Skip to content

[roottest] use cmake for several io tests #19169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025

Conversation

linev
Copy link
Member

@linev linev commented Jun 25, 2025

  • root/io/directory- use unique file names to let run tests in parallel
  • root/io/emulated - use ROOTEXE_OPTS to load pre-compiled headers
  • root/io/event01 - delete completely, not compiled, missing source files,
  • root/io/fakeClass - several tests marked as WILLFAIL, same as in Makefile

linev added 4 commits June 25, 2025 15:47
Use different file names inside to let run tests in parallel
Mark methods as override
Was not tested, source code Event.cxx was not exists
Trying to adopt code from io/event fails
Major tests was failing already with Makefile - mark them so also in cmake
Provide also ref file for printLittle macro, it works normally
@linev linev force-pushed the roottest_io_event branch from 1f3f999 to 67772bb Compare June 25, 2025 13:49
Copy link

github-actions bot commented Jun 26, 2025

Test Results

    20 files      20 suites   3d 14h 43m 42s ⏱️
 3 089 tests  3 089 ✅ 0 💤 0 ❌
60 180 runs  60 180 ✅ 0 💤 0 ❌

Results for commit d47a19f.

♻️ This comment has been updated with latest results.

@linev linev closed this Jun 26, 2025
@linev linev reopened this Jun 26, 2025
@pcanal
Copy link
Member

pcanal commented Jun 26, 2025

One of the windows failures contains:

LINK : fatal error LNK1104: cannot open file 'C:\ROOT-CI\build\bin\libCling.dll' [C:\ROOT-CI\build\core\metacling\src\Cling.vcxproj]

which is likely to be cause by one of (c)test triggering a full rebuild of ROOT.

@linev linev closed this Jun 27, 2025
@linev linev deleted the roottest_io_event branch June 27, 2025 06:05
@linev linev restored the roottest_io_event branch June 27, 2025 06:06
@linev linev reopened this Jun 27, 2025
@linev linev requested a review from pcanal June 27, 2025 16:04
@dpiparo
Copy link
Member

dpiparo commented Jun 27, 2025

@pcanal do you think this is ready for approval? The Win failure seemed to be spurious...

@linev
Copy link
Member Author

linev commented Jun 27, 2025

Last CI run was without failures.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@linev linev merged commit a437a2f into root-project:master Jul 1, 2025
66 of 73 checks passed
@linev linev deleted the roottest_io_event branch July 1, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants