Skip to content

[skip-ci][ntuple] Improve RNTupleWriter doc #19171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

[skip-ci][ntuple] Improve RNTupleWriter doc #19171

merged 2 commits into from
Jun 26, 2025

Conversation

silverweed
Copy link
Contributor

This Pull request:

Improves the documentation of RNTupleWriter, in particular Recreate and Append.

This PR fixes #19168

@silverweed silverweed self-assigned this Jun 25, 2025
@silverweed silverweed requested a review from jblomer as a code owner June 25, 2025 10:28
hahnjo
hahnjo reviewed Jun 25, 2025
View reviewed changes
hageboeck
hageboeck reviewed Jun 25, 2025
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better for RNTupleWriter, thanks, but see the comments below.

What about the part on RNTuple, would you be willing to consider this, too?

@silverweed
Copy link
Contributor Author

What about the part on RNTuple, would you be willing to consider this, too?

Yes, I will append another commit to address that as well

hageboeck
hageboeck approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@silverweed silverweed merged commit faf14f6 into root-project:master Jun 26, 2025
7 checks passed
@silverweed silverweed deleted the ntuplewriter_doc branch June 26, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahnjo hahnjo hahnjo left review comments

@maszyman maszyman maszyman left review comments

@hageboeck hageboeck hageboeck approved these changes

@enirolf enirolf Awaiting requested review from enirolf

@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

Assignees

@silverweed silverweed

Labels
in:Documentation in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation of RNTupleWriter / RNTuple could be improved a bit
4 participants
@silverweed @hahnjo @maszyman @hageboeck