Skip to content

[test] add test for misspelled branch name in ttree draw #19172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Tests https://its.cern.ch/jira/browse/ROOT-8577

@dpiparo
Copy link
Member

dpiparo commented Jun 25, 2025

Thanks first of all to verify that the old issue linked above has been fixed, and also for this nice test.
Before merging, if you agree, I would propose 2 things:

  1. that all changes are squashed in 1 commit
  2. the commented code in the C++ code of the test is removed
    Would it be OK to implement the two changes above?

Copy link

github-actions bot commented Jun 25, 2025

Test Results

    20 files      20 suites   3d 8h 23m 38s ⏱️
 3 045 tests  3 045 ✅ 0 💤 0 ❌
59 310 runs  59 310 ✅ 0 💤 0 ❌

Results for commit adcccc9.

♻️ This comment has been updated with latest results.

Tests https://its.cern.ch/jira/browse/ROOT-8577

[test] add more misspelled cases

[test] add missing dependency
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guitargeek guitargeek merged commit 76850c5 into root-project:master Jun 26, 2025
24 of 25 checks passed
@ferdymercury ferdymercury deleted the wrongbranchname branch June 27, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants