[Tutorials] Fix IMT tutorials, and run them in parallel #19195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a problem with escaping a command line, IMT tutorials in C++ weren't running at all. root: unrecognized option '-e "ROOT::EnableImplicitMT(4)"' Try 'root --help' for more information. 2965/2993 Test root-project#678: tutorial-analysis-dataframe-df102_NanoAODDimuonAnalysis ............. Passed 0.15 sec Here, we move to using the environment variable ROOT_MAX_THREADS.
When running `ctest -R df10 -j16`, only a single tutorial runs at a time, because they share a global RESOURCE_LOCK. However, given that ROOT actually honours ROOT_MAX_THREADS, it's safe now to remove the resource lock and set the number of CPUs in CMake. In this way, four IMT tutorials would run with 4 threads each in a 16-core machine.
Since ROOT honours ROOT_MAX_THREADS, no more IMT wrappers are required for running tutorials.
Test Results 20 files 20 suites 3d 12h 30m 29s ⏱️ Results for commit 8f4f327. ♻️ This comment has been updated with latest results. |
Ruff currently fails to lint when a python file is deleted from the project.
hageboeck
force-pushed
the
fixIMTTutorials
branch
from
f8f008e to
8f4f327
Compare
dpiparo
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-e "xxx", which arrives as a single argument in root. root was exiting with status 0, so the tests wouldn't run. (In a subsequent PR, it will exit with status 2, so future mistakes can be caught.)root -e, now useROOT_MAX_THREADSto limit the number of worker threads.